[FIX] theme_avantgarde: s_carousel text contrast #1021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@odoo/rd-website |
|
@robodoo delegate=chrisdt1998 Although, is that really a thing to do in stable? 🤔 |
|
@mano-odoo after discussing with QSM, please could you target this branch to master? Generally we avoid changing XML in stable and in this case, this change isn't critical (the user can just manually change the text color) so it's sufficient to just do the change on master IMO. Thanks :) |
The `o_cc3` is rendering a white color depending on the the palette. Using `o_cc5` ensure a white text on most palettes. task-4381722
mano-odoo
force-pushed
the
18.0-avantgarde-s_carousel-contrast-mano
branch
from
84cd672 to
f40aa7a
Compare
|
@chrisdt1998 should be good to go (sorry forgot to ping again) Thanks a lot! |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Feb 20, 2025
The `o_cc3` is rendering a white color depending on the the palette. Using `o_cc5` ensure a white text on most palettes. task-4381722 closes #1021 Signed-off-by: Christopher du Toit (chto) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
o_cc3is rendering a white color depending on the the palette. Usingo_cc5ensure a white text.task-4381722